Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable CodeCov comments #2851

Merged
merged 1 commit into from
Nov 20, 2023
Merged

chore: disable CodeCov comments #2851

merged 1 commit into from
Nov 20, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Nov 16, 2023 •
edited by coderabbitai bot
Loading

During Thursday sync, we agreed to try disabling the CodeCov comments on PRs b/c they can be noisy. Note: the code coverage on PRs still gets uploaded to CodeCov via make test-coverage

Ref: https://docs.codecov.com/docs/pull-request-comments#disable-comment

Summary by CodeRabbit

  • Chores
    • Updated configuration to disable automated comments from the code coverage tool.

@rootulp rootulp requested a review from staheri14 November 16, 2023 16:34
@rootulp rootulp self-assigned this Nov 16, 2023
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 16, 2023 •
edited
Loading

Walkthrough

The change involves a configuration update to the Codecov integration within a project. Specifically, it disables the automatic commenting feature of Codecov on pull requests by setting the comment functionality to false.

Changes

File Change Summary
.github/codecov.yml Added comment: false to disable automatic comments by Codecov

🐇 In the fall, as leaves descend,
We tweak our code, refine, amend.
No more comments cluttering the view,
Just silent updates, as we hop to the new. 🍂

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@celestia-bot celestia-bot requested a review from a team November 16, 2023 16:34
coderabbitai[bot]
coderabbitai bot reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fc03393 and 566eb4e.
Files selected for processing (1)
  • .github/codecov.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/codecov.yml

staheri14
staheri14 approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cmwaters
cmwaters approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any point to codecov?

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 20, 2023

IMO not really. I don't find it helpful so I originally proposed removing it entirely

@rootulp rootulp merged commit c6554f1 into celestiaorg:main Nov 20, 2023
31 checks passed
@rootulp rootulp deleted the rp/disable-codecov-comments branch November 20, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@evan-forbes evan-forbes evan-forbes approved these changes

@staheri14 staheri14 staheri14 approved these changes

@cmwaters cmwaters cmwaters approved these changes

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rootulp @cmwaters @staheri14 @evan-forbes